Add a possibility for NSE to Unregister itself on termination #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaSkrynnik
force-pushed
the
unregister
branch
from
e1b61a3 to
25b93ac
Compare
Signed-off-by: Nikita Skrynnik <[email protected]>
NikitaSkrynnik
force-pushed
the
unregister
branch
from
0a1efc9 to
f32874d
Compare
denis-tingaikin
approved these changes
Dec 19, 2023
glazychev-art
approved these changes
Dec 19, 2023
glazychev-art
approved these changes
Dec 20, 2023
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Dec 20, 2023
…d-nse-icmp-responder@main PR link: networkservicemesh/cmd-nse-icmp-responder#552 Commit: 27d3791 Author: Artem Glazychev Date: 2023-12-20 15:43:43 +0700 Message: - Merge pull request #552 from NikitaSkrynnik/unregister Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a bool flag to config. If it's true NSE will unregister itself on its termination.
Issue
networkservicemesh/sdk-k8s#456