Simplify by collapsing packages connection/ connectioncontext/ into networkservice/ #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwarnicke
added a commit
to edwarnicke/sdk
that referenced
this pull request
Jan 28, 2020
networkservicemesh/api#12 Requires these changes downstream in sdk/ Signed-off-by: Ed Warnicke <[email protected]>
edwarnicke
added a commit
to edwarnicke/sdk-vppagent
that referenced
this pull request
Jan 28, 2020
This is required to adapt to changes upstream in: networkservicemesh/api#12 Signed-off-by: Ed Warnicke <[email protected]>
edwarnicke
added a commit
to edwarnicke/sdk-vppagent
that referenced
this pull request
Jan 28, 2020
This is required to adapt to changes upstream in: networkservicemesh/api#12 Signed-off-by: Ed Warnicke <[email protected]>
…etworkservice/ Originally, connection and connectioncontext being separate from networkservice were artifacts of the local/remote split in NSM. This corrects that, leaving us with two top level APIs: 1) networkservice - Request/Close/MonitorConnection 2) registry Signed-off-by: Ed Warnicke <[email protected]>
haiodo
approved these changes
Jan 29, 2020
|
+1 from me |
edwarnicke
added a commit
to edwarnicke/sdk-vppagent
that referenced
this pull request
Jan 29, 2020
This is required to adapt to changes upstream in: networkservicemesh/api#12 Signed-off-by: Ed Warnicke <[email protected]>
fkautz
approved these changes
Jan 29, 2020
nickolaev
approved these changes
Jan 30, 2020
| "github.com/networkservicemesh/api/pkg/api/connection" | ||
| "github.com/networkservicemesh/api/pkg/api/connection/mechanisms/common" | ||
| "github.com/networkservicemesh/api/pkg/api/networkservice/mechanisms/common" | ||
|
|
There was a problem hiding this comment.
Nit: remove the blank line here.
haiodo
added a commit
to networkservicemesh/sdk
that referenced
this pull request
Jan 30, 2020
* Adapt to api/ simplification networkservicemesh/api#12 Requires these changes downstream in sdk/ Signed-off-by: Ed Warnicke <[email protected]> * Update to latest API Signed-off-by: Andrey Sobolev <[email protected]> Co-authored-by: Andrey Sobolev <[email protected]>
edwarnicke
added a commit
to edwarnicke/sdk-vppagent
that referenced
this pull request
Jan 30, 2020
This is required to adapt to changes upstream in: networkservicemesh/api#12 Signed-off-by: Ed Warnicke <[email protected]> Fix dependencies Signed-off-by: Andrey Sobolev <[email protected]> Signed-off-by: Ed Warnicke <[email protected]>
edwarnicke
added a commit
to edwarnicke/sdk-vppagent
that referenced
this pull request
Jan 30, 2020
This is required to adapt to changes upstream in: networkservicemesh/api#12 Signed-off-by: Ed Warnicke <[email protected]> Fix dependencies Signed-off-by: Andrey Sobolev <[email protected]> Signed-off-by: Ed Warnicke <[email protected]>
haiodo
pushed a commit
to networkservicemesh/sdk-vppagent
that referenced
this pull request
Jan 30, 2020
This is required to adapt to changes upstream in: networkservicemesh/api#12 Signed-off-by: Ed Warnicke <[email protected]> Fix dependencies Signed-off-by: Andrey Sobolev <[email protected]> Signed-off-by: Ed Warnicke <[email protected]>
edwarnicke
added a commit
to edwarnicke/api
that referenced
this pull request
Jan 30, 2020
networkservicemesh#10 brought in SRIOV changes after the simplification from: networkservicemesh#12 and initialism fixes from: networkservicemesh#11 This fixes those. Signed-off-by: Ed Warnicke <[email protected]>
edwarnicke
added a commit
to edwarnicke/api
that referenced
this pull request
Jan 30, 2020
networkservicemesh#10 brought in SRIOV changes after the simplification from: networkservicemesh#12 and initialism fixes from: networkservicemesh#11 This fixes those. Signed-off-by: Ed Warnicke <[email protected]>
fkautz
pushed a commit
that referenced
this pull request
Jan 30, 2020
#10 brought in SRIOV changes after the simplification from: #12 and initialism fixes from: #11 This fixes those. Signed-off-by: Ed Warnicke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, connection and connectioncontext being separate from networkservice
were artifacts of the local/remote split in NSM. This corrects that,
leaving us with two top level APIs: