Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ci to go v1.23.3 #85

Merged
merged 5 commits into from
Nov 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .ci/yamllint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ rules:
truthy: disable
# 80 chars should be enough, but don't fail if a line is longer
line-length: disable
comments:
min-spaces-from-content: 1
denis-tingaikin marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: 1.20.12
go-version: 1.23.3
- name: Build
run: go build -race ./...
- name: Test
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/checkgomod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: 1.20.12
go-version: 1.23.3
- run: go mod tidy
- name: Check for changes in go.mod or go.sum
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cmd-gogenerate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: 1.20.12
go-version: 1.23.3
- run: go generate ./...
- name: Check for changes
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker-build-and-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: 1.20.12
go-version: 1.23.3
- name: Build container
run: docker build .
- name: Run tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: 1.20.12
go-version: 1.23.3
- name: Build ${NAME}:${GITHUB_SHA::8} image
run: docker build . -t "${ORG}/${NAME}:${GITHUB_SHA::8}" --target runtime
- name: Build ${NAME}:latest image
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/golangci-lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
linter-version:
description: version of golangci-lint
type: string
default: v1.53.3
default: v1.60.3
required: false
jobs:
golangci-lint:
Expand All @@ -20,7 +20,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: 1.20.12
go-version: 1.23.3
- name: golangci-lint
uses: golangci/golangci-lint-action@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-dependent-repositories.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
token: ${{ secrets.token }}
- uses: actions/setup-go@v5
with:
go-version: 1.20.12
go-version: 1.23.3
- name: Update ${{ matrix.repository }} locally
working-directory: networkservicemesh/${{ matrix.repository }}
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/resolve-conflicts.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: 1.20.12
go-version: 1.23.3
- name: Update version manually
run: |
branch=${{ inputs.pr_branch_ref }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sdk-gogenerate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
version: '3.8.0'
- uses: actions/setup-go@v5
with:
go-version: 1.20.12
go-version: 1.23.3
- name: Install proto-gen-go
run: go install github.com/golang/protobuf/[email protected]
- name: Install go-syncmap
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-dependent-repositories-gomod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
token: ${{ secrets.token }}
- uses: actions/setup-go@v5
with:
go-version: 1.20.12
go-version: 1.23.3
- name: Update ${{ matrix.repository }} locally
working-directory: networkservicemesh/${{ matrix.repository }}
run: |
Expand Down
12 changes: 6 additions & 6 deletions workflow-templates/cmd-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: 1.20.12
go-version: 1.23.3
- name: Build
run: go build -race ./...

Expand All @@ -46,11 +46,11 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: 1.20.12
go-version: 1.23.3
- name: golangci-lint
uses: golangci/golangci-lint-action@v4
with:
version: v1.35.0
version: v1.60.3

excludeFmtErrorf:
name: exclude fmt.Errorf
Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: 1.20.12
go-version: 1.23.3
- run: go mod tidy
- name: Check for changes
run: |
Expand All @@ -100,7 +100,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: 1.20.12
go-version: 1.23.3
- run: go generate ./...
- name: Check for changes
run: |
Expand All @@ -125,7 +125,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: 1.20.12
go-version: 1.23.3
- name: Build container
run: docker build .
- name: Run tests
Expand Down
2 changes: 1 addition & 1 deletion workflow-templates/docker-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: 1.20.12
go-version: 1.23.3
- name: Build ${NAME}:${GITHUB_SHA::8} image
run: docker build . -t "${ORG}/${NAME}:${GITHUB_SHA::8}" --target runtime
- name: Build ${NAME}:latest image
Expand Down