-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #64 #65
Fixed #64 #65
Conversation
-code clean up from previous commit.
-Implement light-rest-4j networknt#64 for Swagger ValidatorHandler
…velop merge local from remote
This looks fine to me, @ddobrin please confirm |
I have reviewed both light-rest-4j and json-schema-validator as they are related changes. In general I am OK with the change but there might be small improvements to the code base.
Thanks a lot for the effort. It is a very big change. |
Thank you for reviewing.
I get your point, I'll change the config in json-schema-validator instead of in light-rest-4j.
Sorry, I didn't pay attention the file name, I thought it's a typo missing "}", I'll change it back. |
made changes based on comments of #65
-fixed #64
-since this project depends on networknt/json-schema-validator, also need to update json-schema-validator to fix this issue.
-to avoid confusion for naming "ValidatorConfig" in json-schema-validator, change "ValidatorConfig" to "ValidatorHandlerConfig"