Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenApiHelper class will not fail when the optional servers section is not provided #63

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

zabooma
Copy link

@zabooma zabooma commented Nov 23, 2018

Related to #62

@DSchrupert DSchrupert self-requested a review November 23, 2018 20:43
@zabooma zabooma requested a review from dguncb November 23, 2018 21:41
Copy link
Member

@DSchrupert DSchrupert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dguncb)

@DSchrupert DSchrupert merged commit 54d997c into networknt:develop Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants