Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 928]: Fix getSchema() anchor fragment lookup. #930

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[Issue 928]: Fix getSchema() anchor fragment lookup. #930

merged 1 commit into from
Jan 24, 2024

Conversation

crutcher
Copy link
Contributor

@crutcher crutcher commented Jan 23, 2024 •
edited
Loading

#928

this makes JsonSchemaFactory.getSchema("...#anchor") work.

@crutcher crutcher changed the title Fix getSchema() anchor fragment lookup. [Issue 928]: Fix getSchema() anchor fragment lookup. Jan 23, 2024
justin-tay
justin-tay approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@justin-tay justin-tay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@stevehu stevehu merged commit f3825f3 into networknt:master Jan 24, 2024
4 checks passed
@stevehu
Copy link
Contributor

stevehu commented Jan 24, 2024

@crutcher @justin-tay Thanks a lot for your help.

@exceptionfactory exceptionfactory mentioned this pull request Feb 14, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-tay justin-tay justin-tay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crutcher @stevehu @justin-tay