Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch APR in docker image thats is used to cross-compile to remove li… #891

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

normanmaurer
Copy link
Member

…bcrypt dependency.

Motivation:

We don't need to depend on libcrypt when cross-compiling. We already don't depend on it when we don't cross-compile

Modifications:

Patch APR as part of the docker image creation and so remove libcrypt dependency

Result:

Fixes #888

…bcrypt dependency.

Motivation:

We don't need to depend on libcrypt when cross-compiling. We already don't depend on it when we don't cross-compile

Modifications:

Patch APR as part of the docker image creation and so remove libcrypt dependency

Result:

Fixes #888
@normanmaurer
Copy link
Member Author

Verified there is no libcrypt linking anymore with this PR:

root@71991d92312f:/tmp/build-pr-centos7-aarch64-jars/boringssl-static/target# ldd META-INF/native/libnetty_tcnative_linux_aarch_64.so
	linux-vdso.so.1 (0x0000ffff8518a000)
	librt.so.1 => /lib/aarch64-linux-gnu/librt.so.1 (0x0000ffff84f34000)
	libdl.so.2 => /lib/aarch64-linux-gnu/libdl.so.2 (0x0000ffff84f20000)
	libc.so.6 => /lib/aarch64-linux-gnu/libc.so.6 (0x0000ffff84dad000)
	libpthread.so.0 => /lib/aarch64-linux-gnu/libpthread.so.0 (0x0000ffff84d7c000)
	/lib/ld-linux-aarch64.so.1 (0x0000ffff8515a000)

cc @slandelle

@flozano
Copy link

flozano commented Oct 24, 2024

now it also depends on pthread like x86_64 non-crosscompiled 👯

@normanmaurer normanmaurer added this to the 2.0.67.Final milestone Oct 24, 2024
@slandelle
Copy link

Awesome, thanks a lot Norman!

@flozano
Copy link

flozano commented Oct 24, 2024

thank you!!!

@normanmaurer normanmaurer merged commit 80952b2 into main Oct 24, 2024
7 checks passed
@normanmaurer normanmaurer deleted the cross_compile_libcrypt branch October 24, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libcrypt: arm64 / x86_64 different dependencies on EL9
3 participants