-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable usage of sys_siglist function to workaround issues on alpine #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When we try to use our static compiled version on alpine it fails due missing sys_siglist. We can workaround this by letting apr use its own implementation. Modifications: Use ac_cv_have_decl_sys_siglist=no when compiling APR. Result: netty-tcnative-boringssl-static should be useable on alpine. Fixes #853
normanmaurer
force-pushed
the
siglist
branch
from
February 26, 2024 15:57
be37954
to
3813a00
Compare
ejona86
approved these changes
Feb 26, 2024
ok problem is still there... need to investigate further |
normanmaurer
force-pushed
the
siglist
branch
from
February 28, 2024 15:15
923b830
to
1e8466a
Compare
Wohoo... This worked:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When we try to use our static compiled version on alpine it fails due missing sys_siglist. We can workaround this by letting apr use its own implementation.
Modifications:
Use ac_cv_have_decl_sys_siglist=no when compiling APR.
Result:
netty-tcnative-boringssl-static should be useable on alpine. Fixes #853