Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boringssl): fix incorrect build profile for osx intel cross compile #836

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix(boringssl): fix incorrect build profile for osx intel cross compile #836

merged 1 commit into from
Oct 27, 2023

Conversation

zekronium
Copy link
Contributor

Motivation:

boringssl-static profile mac-intel-cross-compile incorrectly sets arch resulting in osx-osx-x86_64 build classifier.
It also wrongfully sets the native lib name to libnetty_tcnative_osx_osx_64, making netty-handler unable to find it

If the intention of this profile was to build cross platform (from linux to mac), then os.detected.name can be overridden to still produce the similar result.

<os.detected.name>osx</os.detected.name>

Modifications:
Adjust arch to x86_64 in maven profile for boringssl static

Result:
./mvn -Pmac-intel-cross-compile -am -pl boringssl-static clean package builds correctly on an apple silicon system

@normanmaurer normanmaurer added this to the 2.0.63.Final milestone Oct 27, 2023
@normanmaurer normanmaurer merged commit f73e908 into netty:main Oct 27, 2023
7 checks passed
@normanmaurer
Copy link
Member

@zekronium thanks a lot !

@zekronium zekronium deleted the fix_osx_cross_build branch October 27, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants