Fix memory leak when creating and destroying a lot of context #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: During introducing #759 I missed to add a free call which did introduce a small memory leak. This was not noticable for most users as creating and destroying of SSL context is usually very rare. That said some users might still do this and so notice the leak. Modifications: - Add missing free(...) call to match calloc(...) - Move code of one function to the other as it was the only calling function. This simplifies the code and makes it less error-prone Result: Fixes #788
|
/cc @slandelle @notdryft |
franz1981
approved these changes
May 5, 2023
There was a problem hiding this comment.
@normanmaurer you can give a shot to the async profiler native memory leak branch!
|
We're currently testing it against the async profiler nativemem mode ourselves! |
|
I could not reproduce a leak anymore with this pulled in. Once you confirm it as well I will do a release |
|
Great @notdryft let me know if that worked too! |
normanmaurer
added a commit
that referenced
this pull request
Sep 19, 2023
Motiviation: In the past we removed the usage of apr by static linking against stdc++. While at first this seemed like a good idea it has proven to introduce problems on various platforms. Because of these problems we should better revert the changes and just link against apr again. Modifications: - Revert "Fix memory leak when creating and destroying a lot of context (#790)" fd8fb2a. - Revert "Fix possible corruption / segfault when using atomics (#774)" 11ff708. - Revert "Fix segfault which was caused by not creating the ticket_keys_new atomic (#772)" 196f935. - Revert "Fix format usage" eecaaa8. - Revert "Link libstdc++ statically on linux" a288f03. - Revert "rename functions for consistency" 7ee7804. - Revert "Remove dependency on apr by using c++11 / c++14 features" 8740651. Result: Fixes #798 , #789
normanmaurer
added a commit
that referenced
this pull request
Sep 21, 2023
Motiviation: In the past we removed the usage of apr by static linking against stdc++. While at first this seemed like a good idea it has proven to introduce problems on various platforms. Because of these problems we should better revert the changes and just link against apr again. Modifications: - Revert "Fix memory leak when creating and destroying a lot of context (#790)" fd8fb2a. - Revert "Fix possible corruption / segfault when using atomics (#774)" 11ff708. - Revert "Fix segfault which was caused by not creating the ticket_keys_new atomic (#772)" 196f935. - Revert "Fix format usage" eecaaa8. - Revert "Link libstdc++ statically on linux" a288f03. - Revert "rename functions for consistency" 7ee7804. - Revert "Remove dependency on apr by using c++11 / c++14 features" 8740651. - Update APR version Result: Fixes #798 , #789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
During introducing #759 I missed to add a free call which did introduce a small memory leak. This was not noticable for most users as creating and destroying of SSL context is usually very rare. That said some users might still do this and so notice the leak.
Modifications:
Result:
Fixes #788