Motivation:

tcnative should provide declarative modules for the set of its artifacts. Modifications: - remove the automatic module name declaration (META-INF/MANIFEST entry) - use the module-info maven plugin to generate module-info descriptors in META-INF/versions/11/module-info.class - the build produces multi release jars - run twice the module-info plugin and avoid copying the generated module-info.class when building the native jar, so the default jar uses io.netty.internal.tcnative as a module name, instead of the same module name with classifier Result: tcnative provides declarative java modules.
netty · Aug 10, 2024 · fa7d15b · fa7d15b
1 parent fcda2f7
commit fa7d15b
Show file tree

Hide file tree

Showing 6 changed files with 45 additions and 13 deletions.
diff --git a/boringssl-static/pom.xml b/boringssl-static/pom.xml
@@ -63,7 +63,7 @@
     <ldflags>-L${boringsslHome}/ssl -L${boringsslHome}/crypto -lssl -lcrypto</ldflags>
     <skipJapicmp>true</skipJapicmp>
     <!-- We need to use the same module name for all our "native" impls as only one should be loaded -->
-    <javaModuleName>${javaModuleNameNative}</javaModuleName>
+    <javaModuleName>${javaDefaultModuleName}</javaModuleName>
   </properties>
 
   <dependencies>
@@ -277,7 +277,7 @@
                     </if>
 
                     <copy todir="${nativeJarWorkdir}">
-                      <zipfileset src="${defaultJarFile}" />
+                      <zipfileset src="${defaultJarFile}" excludes="META-INF/versions/**/module-info.class" />
                     </copy>
                     <copy todir="${nativeJarWorkdir}" includeEmptyDirs="false">
                       <zipfileset dir="${nativeLibOnlyDir}/META-INF/native" />
@@ -555,7 +555,7 @@
                     </if>
 
                     <copy todir="${nativeJarWorkdir}">
-                      <zipfileset src="${defaultJarFile}" />
+                      <zipfileset src="${defaultJarFile}" excludes="META-INF/versions/**/module-info.class" />
                     </copy>
                     <copy todir="${nativeJarWorkdir}" includeEmptyDirs="false">
                       <zipfileset dir="${nativeLibOnlyDir}/META-INF/native" />
@@ -890,7 +890,7 @@
                     </if>
 
                     <copy todir="${nativeJarWorkdir}">
-                      <zipfileset src="${defaultJarFile}" />
+                      <zipfileset src="${defaultJarFile}" excludes="META-INF/versions/**/module-info.class" />
                     </copy>
                     <copy todir="${nativeJarWorkdir}" includeEmptyDirs="false">
                       <zipfileset dir="${nativeLibOnlyDir}/META-INF/native" />
@@ -1309,7 +1309,7 @@
                     <taskdef resource="net/sf/antcontrib/antcontrib.properties" />
 
                     <copy todir="${nativeJarWorkdir}">
-                      <zipfileset src="${defaultJarFile}" />
+                      <zipfileset src="${defaultJarFile}" excludes="META-INF/versions/**/module-info.class" />
                     </copy>
                     <copy todir="${nativeJarWorkdir}" includeEmptyDirs="false">
                       <zipfileset dir="${nativeLibOnlyDir}/META-INF/native" />
@@ -1556,7 +1556,7 @@
                     <taskdef resource="net/sf/antcontrib/antcontrib.properties" />
 
                     <copy todir="${nativeJarWorkdir}">
-                      <zipfileset src="${defaultJarFile}" />
+                      <zipfileset src="${defaultJarFile}" excludes="META-INF/versions/**/module-info.class" />
                     </copy>
                     <copy todir="${nativeJarWorkdir}" includeEmptyDirs="false">
                       <zipfileset dir="${nativeLibOnlyDir}/META-INF/native" />

diff --git a/libressl-static/pom.xml b/libressl-static/pom.xml
@@ -40,7 +40,7 @@
     <maven.deploy.skip>true</maven.deploy.skip>
     <skipJapicmp>true</skipJapicmp>
     <!-- We need to use the same module name for all our "native" impls as only one should be loaded -->
-    <javaModuleName>${javaModuleNameNative}</javaModuleName>
+    <javaModuleName>${javaDefaultModuleName}</javaModuleName>
   </properties>
 
   <build>
@@ -112,7 +112,7 @@
             <configuration>
               <target>
                 <copy todir="${nativeJarWorkdir}">
-                  <zipfileset src="${defaultJarFile}" />
+                  <zipfileset src="${defaultJarFile}" excludes="META-INF/versions/**/module-info.class" />
                 </copy>
                 <copy todir="${nativeJarWorkdir}" includeEmptyDirs="false">
                   <zipfileset dir="${nativeLibOnlyDir}/META-INF/native" />

diff --git a/openssl-classes/src/main/java/module-info.yml b/openssl-classes/src/main/java/module-info.yml
@@ -0,0 +1,2 @@
+exports:
+  - package: io.netty.internal.tcnative
diff --git a/openssl-dynamic/pom.xml b/openssl-dynamic/pom.xml
@@ -36,7 +36,7 @@
     <nativeSourceDirectory />
     <skipJapicmp>true</skipJapicmp>
     <!-- We need to use the same module name for all our "native" impls as only one should be loaded -->
-    <javaModuleName>${javaModuleNameNative}</javaModuleName>
+    <javaModuleName>${javaDefaultModuleName}</javaModuleName>
   </properties>
 
   <build>
@@ -77,7 +77,7 @@
             <configuration>
               <target>
                 <copy todir="${nativeJarWorkdir}">
-                  <zipfileset src="${defaultJarFile}" />
+                  <zipfileset src="${defaultJarFile}" excludes="META-INF/versions/**/module-info.class" />
                 </copy>
                 <copy todir="${nativeJarWorkdir}" includeEmptyDirs="false">
                   <zipfileset dir="${nativeLibOnlyDir}/META-INF/native" />

diff --git a/openssl-static/pom.xml b/openssl-static/pom.xml
@@ -39,7 +39,7 @@
     <maven.deploy.skip>true</maven.deploy.skip>
     <skipJapicmp>true</skipJapicmp>
     <!-- We need to use the same module name for all our "native" impls as only one should be loaded -->
-    <javaModuleName>${javaModuleNameNative}</javaModuleName>
+    <javaModuleName>${javaDefaultModuleName}</javaModuleName>
   </properties>
 
   <build>
@@ -109,7 +109,7 @@
             <configuration>
               <target>
                 <copy todir="${nativeJarWorkdir}">
-                  <zipfileset src="${defaultJarFile}" />
+                  <zipfileset src="${defaultJarFile}" excludes="META-INF/versions/**/module-info.class" />
                 </copy>
                 <copy todir="${nativeJarWorkdir}" includeEmptyDirs="false">
                   <zipfileset dir="${nativeLibOnlyDir}/META-INF/native" />

diff --git a/pom.xml b/pom.xml
@@ -233,6 +233,36 @@
         </configuration>
       </plugin>
 
+      <plugin>
+        <groupId>io.github.dmlloyd.module-info</groupId>
+        <artifactId>module-info</artifactId>
+        <version>2.1</version>
+        <executions>
+          <execution>
+            <id>default-jar-module-info</id>
+            <phase>process-classes</phase>
+            <configuration>
+              <moduleName>${javaModuleName}</moduleName>
+              <outputDirectory>${project.build.outputDirectory}/META-INF/versions/11/</outputDirectory>
+            </configuration>
+            <goals>
+              <goal>generate</goal>
+            </goals>
+          </execution>
+          <execution>
+            <id>native-jar-module-info</id>
+            <phase>process-classes</phase>
+            <configuration>
+              <moduleName>${javaModuleNameNative}</moduleName>
+              <outputDirectory>${nativeJarWorkdir}//META-INF/versions/11/</outputDirectory>
+            </configuration>
+            <goals>
+              <goal>generate</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
+
       <plugin>
         <artifactId>maven-surefire-plugin</artifactId>
         <version>2.22.2</version>
@@ -439,7 +469,7 @@
                   <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
                 </manifest>
                 <manifestEntries>
-                  <Automatic-Module-Name>${javaModuleName}</Automatic-Module-Name>
+                  <Multi-Release>true</Multi-Release>
                 </manifestEntries>
                 <index>true</index>
                 <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		exports:
		- package: io.netty.internal.tcnative