Avoid static state #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When statically compiled, the same netty-jni-util may be used by multiple separate JNI libraries. In this situation there is only one copy of static variables, so it is only safe to use static variables in cases where they can safely be reused. That's not the case for the current staticPackagePrefix. Modifications: Force the caller to manage the static state, which can be unique per usage. Result: Static compilation is available again for JNI libraries that supported static compilation before depending on netty-jni-util. Fixes netty#5.
normanmaurer
approved these changes
Mar 24, 2021
|
FYI, I don't have write permission to this repo. |
|
@ejona86 now you have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When statically compiled, the same netty-jni-util may be used by
multiple separate JNI libraries. In this situation there is only one
copy of static variables, so it is only safe to use static variables in
cases where they can safely be reused. That's not the case for the
current staticPackagePrefix.
Modifications:
Force the caller to manage the static state, which can be unique per
usage.
Result:
Static compilation is available again for JNI libraries that supported
static compilation before depending on netty-jni-util. Fixes #5.