Correctly handle optional client auth on the client #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When client auth is optional we must not fail the handshake on the client side when no keymanager was configured on the client side. Modifications: - Fix handling on the client-side - Add testcase - Fix test Result: Fixes #566
ramidzkh
reviewed
Aug 21, 2023
| @@ -102,8 +102,7 @@ long[] handle(long ssl, byte[] keyTypeBytes, byte[][] asn1DerEncodedPrincipals, | |||
|
|
|||
| try { | |||
| if (keyManager == null) { | |||
| engineMap.remove(ssl); | |||
| return null; | |||
| return new long[] { 0, 0 }; | |||
There was a problem hiding this comment.
What if there is a keyManager but it doesn't contain applicable valid key for the requested issuers (selectKeyMaterialClientSide below returning null)?
There was a problem hiding this comment.
Good catch... fixing as we speak
|
@ramidzkh PTAL again |
ramidzkh
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When client auth is optional we must not fail the handshake on the client side when no keymanager was configured on the client side.
Modifications:
Result:
Fixes #566