Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FbGetSCCMAdmins (plus other refactors) #1

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

rasta-mouse
Copy link

The main purpose of this PR was to add FbGetSCCMAdmins which reads the site administrative users from SMS_Admin. Example output:

[*] Action: Get SCCM Admins
UserName: SCM-1\Administrator
SID: S-1-5-21-303941143-420902481-3534137921-500
Roles: Full Administrator
Security Scopes: All
Collections: All Systems, All Users and User Groups

UserName: LAB\rasta
SID: S-1-5-21-2629820871-389766067-3233314696-1106
Roles: Asset Manager, Application Administrator, Security Administrator
Security Scopes: test-scope
Collections: All Users and User Groups, All Desktop and Server Clients

[*] Inspect complete

It also includes some other refactoring and code clean-ups (mostly to satisfy my own OCD, for which I apologise). The main functional change is to add CommandName as a get-only property on ICommand. This way, it is enforced on the command classes, rather than leaving it to the dev to remember. The CommandCollection class now also uses reflection to instantiate each command class, rather than having to manually add each to a dictionary.

Use raw const strings
- Add CommandName as get-only property on ICommand.
- Refactor existing commands.
- Change CommandCollection to load commands via Reflection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant