Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password is readable from container, but not from parameter #426

Closed
janbarasek opened this issue Jul 1, 2020 · 4 comments
Closed

Password is readable from container, but not from parameter #426

janbarasek opened this issue Jul 1, 2020 · 4 comments

Comments

@janbarasek
Copy link
Contributor

Version: 2.7.5

Bug Description

In case of generated Nette Container with password in service (Nette Context) I can read password from source code but I think this password should be hidden (like in parameters):

Snímek obrazovky 2020-07-01 v 15 54 37

Steps To Reproduce

See your callstack to Nette Context.

Expected Behavior

String parameter with can be hidden in source code.

Possible Solution

I think it can be solved by replacing string '<password>' or "<password>" with real password from parameter.

I can send PR if this suggestion make sense.

Thanks.

@dg
Copy link
Member

dg commented Jul 13, 2020

Ok, try to send PR.

@janbarasek
Copy link
Contributor Author

I think instead of this:

Snímek obrazovky 2020-07-14 v 9 42 51

Tracy can support comment annotation for ignoring password part:

Snímek obrazovky 2020-07-14 v 9 44 31

What do you think about?

@dg
Copy link
Member

dg commented Jul 14, 2020

I guess that's the way to do it.

@f3l1x
Copy link
Member

f3l1x commented Jul 14, 2020

Please consider extensions from user-land.

@dg dg closed this as completed in 1547fe6 Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants