hints

nette · Jan 2, 2024 · 52629b1 · 52629b1
1 parent 86bdba4
commit 52629b1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/Bridges/Nette/TracyExtension.php b/src/Bridges/Nette/TracyExtension.php
@@ -60,7 +60,7 @@ public function getConfigSchema(): Nette\Schema\Schema
 	}
 
 
-	public function loadConfiguration()
+	public function loadConfiguration(): void
 	{
 		$builder = $this->getContainerBuilder();
 
@@ -76,7 +76,7 @@ public function loadConfiguration()
 	}
 
 
-	public function afterCompile(Nette\PhpGenerator\ClassType $class)
+	public function afterCompile(Nette\PhpGenerator\ClassType $class): void
 	{
 		$initialize = $this->initialization ?? new Nette\PhpGenerator\Closure;
 		$initialize->addBody('if (!Tracy\Debugger::isEnabled()) { return; }');

diff --git a/src/Tracy/Debugger/Debugger.php b/src/Tracy/Debugger/Debugger.php
@@ -209,7 +209,7 @@ public static function enable(
 		// php configuration
 		if (function_exists('ini_set')) {
 			ini_set('display_errors', '0'); // or 'stderr'
-			ini_set('html_errors', '0');
+			ini_set('html_errors', '0'); // additionally turns off stack trace displaing by xdebug
 			ini_set('log_errors', '0');
 			ini_set('zend.exception_ignore_args', '0');
 		}
@@ -354,6 +354,7 @@ public static function errorHandler(
 	{
 		$error = error_get_last();
 		if (($error['type'] ?? null) === E_COMPILE_WARNING) {
+			// compile-warning does not trigger the handler, so we are testing it now
 			error_clear_last();
 			self::errorHandler($error['type'], $error['message'], $error['file'], $error['line']);
 		}