Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert with custom message. #7

Closed
integer opened this issue Jun 26, 2019 · 2 comments
Closed

Assert with custom message. #7

integer opened this issue Jun 26, 2019 · 2 comments

Comments

@integer
Copy link
Contributor

integer commented Jun 26, 2019

When you have more asserts for one value it is difficult to find which assert failed.

Same issue if you have more complex logic in your assert. For example you asserts relations between two fields of structure. In this case you get error like this
Failed assertion #0 for option 'data › items › 0' with value object. which is not so useful.

What do you think about this feature. May I prepare PR?
@dg
Copy link
Member

dg commented Jul 7, 2019

How would you like to solve it?

integer added a commit to integer/schema that referenced this issue Jul 11, 2019
@integer
Assert with optinal description nette#7
f3a1bb7
@integer integer mentioned this issue Jul 11, 2019
Merged
integer added a commit to integer/schema that referenced this issue Jul 11, 2019
@integer
Assert with optinal description nette#7
88222c5
integer added a commit to integer/schema that referenced this issue Jul 11, 2019
@integer
Assert with optinal description nette#7
9e5851a
integer added a commit to integer/schema that referenced this issue Jul 11, 2019
@integer
Assert with optinal description nette#7
fb99032
integer added a commit to integer/schema that referenced this issue Jul 11, 2019
@integer
Assert with optinal description nette#7
4fb7680
dg pushed a commit that referenced this issue Sep 15, 2019
@integer @dg
Assert with optinal description #7 (#8)
60ba751
@dg
Copy link
Member

dg commented Sep 15, 2019

Merged

@dg dg closed this as completed Sep 15, 2019
dg pushed a commit that referenced this issue Sep 15, 2019
@integer @dg
Assert with optinal description #7 (#8)
d5f673c
dg pushed a commit that referenced this issue Sep 15, 2019
@integer @dg
Assert with optinal description #7 (#8)
8cfb873
dg pushed a commit that referenced this issue Sep 24, 2019
@integer @dg
Assert with optinal description #7 (#8)
2aa0542
dg pushed a commit that referenced this issue Oct 31, 2019
@integer @dg
Assert with optinal description #7 (#8)
a8646a9
dg pushed a commit that referenced this issue Oct 31, 2019
@integer @dg
Assert with optinal description #7 (#8)
cd76b55
dg pushed a commit that referenced this issue Jan 6, 2020
@integer @dg
Assert with optinal description #7 (#8)
febf71f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@integer @dg