-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle for resolving of class names when using withBodyFrom functionality #85
Conversation
That's great, thanks. Could you add a test? |
Yes! Will do it when I have more time :) |
65fcbb1
to
605a107
Compare
I totally understand the first commit with the replacing of class names inside the function bodies, this is of course useful and I merged it. But I don't understand the point of the second commit. On the one hand it goes against type resolving in the Printer, and anyway it would have to be done differently, because the last segment of the class name might not be sufficient, for example in the case of |
In order to create a class from an existing file and move it to another location with another namespace, it was necessary to be able to disable the replacing of class names in function bodies with fully qualified versions, and rather relying on correct use statements.
Also made the change in the most harmless way so nothing breaks 🤞
Hope this is a valuable addition :)