-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method's and function's bodies are copied without name resolve #61
Comments
djaf77
pushed a commit
to superjobru/php-generator
that referenced
this issue
Jun 5, 2020
dg
pushed a commit
that referenced
this issue
Jun 5, 2020
Co-authored-by: Anton Zolotilin <[email protected]>
dg
pushed a commit
that referenced
this issue
Jun 5, 2020
Co-authored-by: Anton Zolotilin <[email protected]>
dg
pushed a commit
that referenced
this issue
Jun 19, 2020
Co-authored-by: Anton Zolotilin <[email protected]>
dg
pushed a commit
that referenced
this issue
Jun 19, 2020
Co-authored-by: Anton Zolotilin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version: 3.4.0
Bug Description
Class generated using Reflection have fully-qualified names, because Reflection return all names as FQN. But method's and function's bodies are copied without fully-qualified name.
Nikic's NodeVisitor\NameResolver resolve name, but not change node's position in file, which used for copying body.
Steps To Reproduce
We have class for reflection:
after
Nette\PhpGenerator\ClassType::withBodiesFrom(MyClass::class);
we'll get:Expected Behavior
We must get FQN in method's and global function's body too.
Possible Solution
There are two way for problem solving:
The text was updated successfully, but these errors were encountered: