Message::buildText(): Trim each text line. #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
reviewed
May 31, 2021
| @@ -382,6 +382,7 @@ protected function buildText(string $html): string | |||
| ]); | |||
| $text = Nette\Utils\Html::htmlToText($html); | |||
| $text = Strings::replace($text, '#[ \t]+#', ' '); | |||
| $text = implode("\n", array_map(static fn(string $line): string => trim($line), explode("\n", str_replace(["\r\n", "\r"], "\n", $text)))); | |||
There was a problem hiding this comment.
static fn(string $line): string => trim($line) can be simply 'trim', or can't?
There was a problem hiding this comment.
It has one difference - PHP calls function internally, so weak typing is used instead of strict types
https://chat.stackoverflow.com/transcript/message/40320863#40320863
There was a problem hiding this comment.
So, should I change it or will we let it go?
dg
added a commit
that referenced
this pull request
Jun 2, 2021
Co-authored-by: David Grudl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, when converting HTML to text, blanks are left at the beginning and end of lines. This modification removes these unnecessary characters (saves storage when serializing messages and unifies formatting).
Thanks!