fixed including of paths with scheme in config loader #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fprochazka
added a commit
to fprochazka/phpstan-compiler
that referenced
this pull request
May 5, 2017
|
@fprochazka Could you add test? |
|
Probably yes, but I'm not sure how to test it. Adding a phar would be a lot of work. Maybe |
Majkl578
reviewed
May 7, 2017
| @@ -48,7 +48,7 @@ public function load(string $file): array | |||
| if (isset($data[self::INCLUDES_KEY])) { | |||
| Validators::assert($data[self::INCLUDES_KEY], 'list', "section 'includes' in file '$file'"); | |||
| foreach ($data[self::INCLUDES_KEY] as $include) { | |||
| if (!preg_match('#([a-z]:)?[/\\\\]#Ai', $include)) { | |||
| if (!preg_match('#([a-z]+:)?[/\\\\]#Ai', $include)) { | |||
There was a problem hiding this comment.
This will also allow i.e. phar:\\ which is not correct.
dg
force-pushed
the
master
branch
2 times, most recently
from
539908c to
9e31491
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
b1bf33b to
abfbe74
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
f5d91ca to
29b3a56
Compare
dg
pushed a commit
that referenced
this pull request
Aug 31, 2017
dg
pushed a commit
that referenced
this pull request
Aug 31, 2017
dg
pushed a commit
that referenced
this pull request
Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including a config in the following way doesn't work