Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure to_be_added_bindprimary_keys targets only the correct binding … #462

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Ensure to_be_added_bindprimary_keys targets only the correct binding … #462

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81ceb53
Ensure to_be_added_bindprimary_keys targets only the correct binding …
Sep 18, 2024
b1fc0ff
Update CHANGELOG.md
sumanth-lingappa Oct 18, 2024
5717fb7
Update CHANGELOG.md
sumanth-lingappa Oct 18, 2024
53455cb
Update CHANGELOG.md
sumanth-lingappa Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [2.6.2] - 2024-09-18
sumanth-lingappa marked this conversation as resolved.
Show resolved Hide resolved

### Fixed

- Ensure to_be_added_bindprimary_keys targets only the correct binding members ([#457])
sumanth-lingappa marked this conversation as resolved.
Show resolved Hide resolved

## [2.6.1] - 2024-04-29

### Fixed
Expand Down Expand Up @@ -169,3 +175,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#367]: https://github.com/netscaler/ansible-collection-netscaleradc/issues/367
[#377]: https://github.com/netscaler/ansible-collection-netscaleradc/issues/377
[#400]: https://github.com/netscaler/ansible-collection-netscaleradc/issues/400
[#457]: https://github.com/netscaler/ansible-collection-netscaleradc/issues/457
sumanth-lingappa marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ build:
ansible-galaxy collection build --force

galaxy_importer: build
python3 -m galaxy_importer.main netscaler-adc-2.2.0.tar.gz
python3 -m galaxy_importer.main netscaler-adc-2.6.2.tar.gz

# build_docs:
# rm -rf _built_docs
Expand Down
2 changes: 1 addition & 1 deletion galaxy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace: netscaler
# The name of the collection. Has the same character restrictions as 'namespace'
name: adc
# The version of the collection. Must be compatible with semantic versioning
version: 2.6.1
version: 2.6.2
# The path to the Markdown (.md) readme file. This path is relative to the root of the collection
readme: README.md
# A list of the collection's content authors. Can be just the name or in the format 'Full Name <email> (url)
Expand Down
5 changes: 4 additions & 1 deletion plugins/module_utils/module_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,10 @@ def sync_single_binding(self, binding_name):
if to_be_added_bindprimary_keys:
self.add_bindings(
binding_name=binding_name,
desired_bindings=desired_binding_members,
desired_bindings=[
x for x in desired_binding_members
if x[get_bindprimary_key(binding_name, x)] in to_be_added_bindprimary_keys
],
)

# If there is any default bindings, after adding the custom bindings, the default bindings will be deleted automatically
Expand Down