Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] sslcert doesn't support any state #295

Closed
fa-elepape opened this issue Nov 2, 2023 · 3 comments
Closed

[BUG] sslcert doesn't support any state #295

fa-elepape opened this issue Nov 2, 2023 · 3 comments
Assignees
Labels

Comments

@fa-elepape
Copy link

Describe the bug
When using netscaler.adc.sslcert, the module fails at the ansible module parameters validation because no state is supported:

{
    "changed": false,
    "msg": "value of state must be one of: , got: present"
}

To Reproduce
Steps to reproduce the behaviour:

  1. My ansible-playbook is
---
- name: netscaler.adc.sslcert bug report
  hosts: localhost
  gather_facts: false

  tasks:
  - netscaler.adc.sslcert:
      state: present
  1. The ansible-playbook command I executed is...
$ ansible-playbook --diff bug-report.yml
PLAY [netscaler.adc.sslcert bug report] **************************************************************************

TASK [netscaler.adc.sslcert] *************************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "value of state must be one of: , got: present"}

PLAY RECAP *******************************************************************************************************
localhost                  : ok=0    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0

Expected behaviour
The sslcert creation succeeds.

Environment (please complete the following information):

$ ansible-galaxy collection list netscaler.adc
Collection    Version
------------- -------
netscaler.adc 2.0.1

$ python3 --version
Python 3.9.16

$ ansible --version
ansible [core 2.13.4]
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['~/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/share/ansible/lib64/python3.9/site-packages/ansible
  ansible collection location = /etc/ansible/collections:/usr/share/ansible/collections
  executable location = /usr/local/bin/ansible
  python version = 3.9.16 (main, May 29 2023, 00:00:00) [GCC 11.3.1 20221121 (Red Hat 11.3.1-4)]
  jinja version = 3.1.2
  libyaml = True

Additional context
The _supported_operations of the sslcert do not include the add or update expected by the get_valid_desired_states function.

@sumanth-lingappa
Copy link
Collaborator

sumanth-lingappa commented Nov 15, 2023

@fa-elepape, thank you for raising this issue.
I acknowledge the bug in the collection for sslcert in specific as well as all the resources with create as action in the NITRO URL.

We will keep this in our planning and update here when it is fixed.

sumanth-lingappa added a commit that referenced this issue Dec 17, 2023
### Added

- introduced new states -- `created` and `imported` ([#295])

### Fixed

- removed default values in `nitro_resource_map.py` ([#313], [#314], [#311])
- default monitor can now be unbound from service ([#312])
- `ip` is now not mandatory for server based resources ([#297])
@sumanth-lingappa
Copy link
Collaborator

This issue is fixed in the latest release 2.1.0. Please check and update the issue accordingly.

@sumanth-lingappa
Copy link
Collaborator

closing this. please update this request if you still face the issue.

Refer below for an example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants