Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repackage ASM code within separate namespace #10

Closed
wants to merge 1 commit into from

Conversation

hzpz
Copy link

@hzpz hzpz commented Mar 3, 2015

See https://code.google.com/p/json-smart/issues/detail?id=52.
I am not sure about the OSGi side of things. Please review and verify that the change does not break the OSGi bundle.

@aborg0
Copy link

aborg0 commented Mar 3, 2015

From OSGi point of view, this is probably fine, I doubt people use json-smart because of asm:asm transitive dependency and they can create their own bundle from it if they prefer. (Or just use the new asm version, which I suspect is the recommended option anyway.) When I suggested to embed it, I forget to make the packages private. With this change the net.minidev:asm bundle should bump its version number to 2.x though.

@hzpz
Copy link
Author

hzpz commented Mar 9, 2015

Thanks for the review! As for the asm dependency (which is still there despite the maven-jarjar-plugin), it might be a better idea to use the maven-shade-plugin. See http://stackoverflow.com/a/5727793/3790806.

@UrielCh
Copy link
Contributor

UrielCh commented Mar 11, 2015

hello,

I understand anything about OSGI.

Could you suggest a patch out of net.minidev.asm json-smart?

should I add:

org.apache.felix
maven-bundle-plugin
2.3.7
true


${project.groupId}.${project.artifactId}
${project.artifactId}
${project.version}
net.minidev.asm,net.minidev.asm.ex


in my ASM pom ?

@UrielCh
Copy link
Contributor

UrielCh commented Mar 11, 2015

Can you check the last Git changes ?

@UrielCh UrielCh closed this Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants