Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test console improvements #736

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Test console improvements #736

merged 1 commit into from
Aug 13, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Aug 9, 2024

Fixes #124

- Remove the requirement to build our own image (requires
  netobserv/network-observability-console-plugin#576)
- Rewrite FAQ entry
- Add make target (make use-test-console)

Fixes netobserv#124
@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Aug 9, 2024
@jotak jotak requested a review from jpinsonneau August 9, 2024 09:32
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.12%. Comparing base (1e3befc) to head (81ef223).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #736   +/-   ##
=======================================
  Coverage   67.12%   67.12%           
=======================================
  Files          74       74           
  Lines        8574     8574           
=======================================
  Hits         5755     5755           
  Misses       2416     2416           
  Partials      403      403           
Flag Coverage Δ
unittests 67.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good ! Thanks @jotak

@jotak
Copy link
Member Author

jotak commented Aug 13, 2024

/approve

Copy link

openshift-ci bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak merged commit 8275dd6 into netobserv:main Aug 13, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to local deployment (kind) the standalone console UI
2 participants