Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-693: use ISO8601 for logging timestamps #206

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Dec 1, 2022

Changed timestamps in epoch milliseconds by something like 2022-12-01T09:53:35.484Z.

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @mariomac

@openshift-ci
Copy link

openshift-ci bot commented Dec 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5a02e02 into netobserv:main Dec 1, 2022
KalmanMeth pushed a commit to KalmanMeth/network-observability-operator that referenced this pull request Feb 13, 2023
- More consistent naming (camel-case) cf netobserv#206
- Add json bindings
- New pipeline builder to make it easier to consume and reuse API model
- Remove garbage files (?) that prevents importing as lib from another
  project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants