Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-727 Update bundle process #205

Merged
merged 3 commits into from
Dec 2, 2022

Conversation

jotak
Copy link
Member

@jotak jotak commented Nov 30, 2022

Requires #200

The bundle process needs to work both for upstream and downstream
Every time someone changes something that would alter the bundle (e.g.
CSV description), they should run "make bundle" (with no options)

It will generate the CSV with injected upstream description.
The downstream description will be updated too, but not injected: this
step will be done later on, in midstream.

@jotak jotak force-pushed the update-bundle-process branch 3 times, most recently from 3fc8b62 to 7f2b006 Compare November 30, 2022 16:00
operators.operatorframework.io.metrics.builder: operator-sdk-v1.25.2
operators.operatorframework.io.bundle.channels.v1: v0.2.x
operators.operatorframework.io.bundle.channel.default.v1: v0.2.x
operators.operatorframework.io.metrics.builder: operator-sdk-v1.22.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we use latest operator-sdk by default or stick to a given version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to enforce a specific version, as long as the produced bundle stays the same, minus that particular line ?
In the new github action to verify the bundle, this line is ignored (as well as the "createdAt" line in CSV)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that, if someone uses a too old operator-sdk that produces different bundle, the github action will throw a failure, so that will force us to upgrade operator-sdk when necessary

The bundle process needs to work both for upstream and downstream
Every time someone changes something that would alter the bundle (e.g.
CSV description), they should run "make bundle" (with no options)

It will generate the CSV with injected upstream description.
The downstream description will be updated too, but not injected: this
step will be done later on, in midstream.
@openshift-ci
Copy link

openshift-ci bot commented Dec 2, 2022

New changes are detected. LGTM label has been removed.

@jotak
Copy link
Member Author

jotak commented Dec 2, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 2, 2022
@jotak jotak merged commit c4186d0 into netobserv:main Dec 2, 2022
@jotak jotak deleted the update-bundle-process branch September 28, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants