Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-447: Changed default FLP retry value to prevent FLP beeing oom-killed #182

Merged

Conversation

OlivierCazade
Copy link
Contributor

No description provided.

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this means we would have only 3 queries in total during a 10s frame before dropping flows ?

If loki is down, should we get the /ready enpoint result before retrying ?

@jotak
Copy link
Member

jotak commented Oct 17, 2022

I think that's a good change. If there's too many outstanding requests, it's FLP that is going to suffer.

Does this means we would have only 3 queries in total during a 10s frame before dropping flows ?

Not sure to get what you mean; to my understanding, the retry mechanism is most often used when rate limit is hit; but the problem is, rate limit is hit in general because FLP processes flows faster than what Loki can handle, so retrying is only post-poning the issue for later and even worsen it as it increases the number of queries to loki. So, in any case that's a "bad" situation, but failing fast prevents the situation to degrade even more.

Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OlivierCazade
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OlivierCazade

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d4d8df2 into netobserv:main Oct 18, 2022
KalmanMeth pushed a commit to KalmanMeth/network-observability-operator that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants