Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default limits to CR #161

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

jotak
Copy link
Member

@jotak jotak commented Sep 2, 2022

(it makes it easier to tune these limits by modifying the CR)

side question: should we change these limit? E.g. raise to, maybe, 800 Mi ?

@jpinsonneau
Copy link
Contributor

If we do that for FLP, should we do it for all components ?

We also need to keep synced this with defaults values from api/v1alpha1/flowcollector_types.go
FYI there is also a PR pending for missing config of eBPF agent: #155

@jotak
Copy link
Member Author

jotak commented Sep 6, 2022

If we do that for FLP, should we do it for all components ?

Yes and it's not just for req/limits, pretty much all options could be defaulted in the sample CR, it helps to have a CR that we can tune without having to refer to any documentation. (I thought we were already doing that, but maybe I was the only one lol)

@jotak
Copy link
Member Author

jotak commented Sep 7, 2022

@jpinsonneau I added the ebpf limits following what you did in your PR. We should merge them +/- together for consistency.
(I haven't tested mine yet, fussy cluster this morning :/ )

@jotak
Copy link
Member Author

jotak commented Sep 7, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit ab50786 into netobserv:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants