Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated labels used by prometheus for metrics produced by flp #150

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

KalmanMeth
Copy link
Contributor

@KalmanMeth KalmanMeth commented Aug 9, 2022

Instead of the labels aggregate and by we now use Service and SrcK8S_Namespace.
This requires use of the recently released flp version v0.1.3.

@jotak
Copy link
Member

jotak commented Aug 9, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 9, 2022
@jotak
Copy link
Member

jotak commented Aug 10, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3a376b6 into netobserv:main Aug 10, 2022
@KalmanMeth KalmanMeth deleted the fix-metric-tags branch October 27, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants