Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console plugin annotation #100

Merged
merged 1 commit into from
May 11, 2022
Merged

Console plugin annotation #100

merged 1 commit into from
May 11, 2022

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented May 11, 2022

Missing console.openshift.io/plugins annotation

An operator can also give console a hint that it has a plugin available through the console.openshift.io/plugins annotations. The annotation tells the console to show a checkbox to enable plugins during operator install. Only users who can edit the console operator config will see the checkbox. The annotation value is a serialized JSON array of strings, where each item is the name of a ConsolePlugin resource the operator will create.
https://github.com/openshift/enhancements/blob/master/enhancements/console/dynamic-plugins.md#delivering-plugins

@openshift-ci
Copy link

openshift-ci bot commented May 11, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from jpinsonneau after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau jpinsonneau requested a review from jotak May 11, 2022 07:22
@jotak
Copy link
Member

jotak commented May 11, 2022

I think it's only relevant in the case our operator is installed before the console operator, which shouldn't happen too often, but why not :)

/lgtm

@jpinsonneau
Copy link
Contributor Author

I think it's only relevant in the case our operator is installed before the console operator, which shouldn't happen too often, but why not :)

That's not my understanding of The annotation tells the console to show a checkbox to enable plugins during operator install

For me it should add an option to enable the plugin here:
image

Check:
openshift/console#8175

@jpinsonneau jpinsonneau merged commit 965da6c into netobserv:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants