Skip to content

Commit

Permalink
NETOBSERV-1665: use v1 for conversionReviewVersions
Browse files Browse the repository at this point in the history
Note we're talking here about versions of ConversionReview (ie.
apiextension), NOT versions of our CRDs

- Use same versions for flowcollector and flowmetrics
- Use just v1 as the only other (v1beta1) was dropped a while ago (kube
  1.22 / 2021)
  • Loading branch information
jotak committed May 28, 2024
1 parent acba911 commit 3be0ed3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
3 changes: 1 addition & 2 deletions bundle/manifests/flows.netobserv.io_flowcollectors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ spec:
namespace: netobserv
path: /convert
conversionReviewVersions:
- v1beta1
- v1beta2
- v1
group: flows.netobserv.io
names:
kind: FlowCollector
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1335,8 +1335,7 @@ spec:
version: 1.6.0-community
webhookdefinitions:
- admissionReviewVersions:
- v1beta1
- v1beta2
- v1
containerPort: 443
conversionCRDs:
- flowcollectors.flows.netobserv.io
Expand Down
3 changes: 1 addition & 2 deletions config/crd/patches/webhook_in_flowcollectors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@ spec:
name: webhook-service
path: /convert
conversionReviewVersions:
- v1beta1
- v1beta2
- v1

0 comments on commit 3be0ed3

Please sign in to comment.