Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-131 POC Sankey chart #555

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Jul 12, 2024

Description

Add sankey chart to panels
image

Dependencies

Based on #551, merge it first

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 53.83481% with 313 lines in your changes missing coverage. Please review.

Project coverage is 56.10%. Comparing base (3d6a89a) to head (c8d51fa).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #555    +/-   ##
========================================
  Coverage   56.10%   56.10%            
========================================
  Files         183      192     +9     
  Lines        9098     9240   +142     
  Branches     1185     1198    +13     
========================================
+ Hits         5104     5184    +80     
- Misses       3623     3685    +62     
  Partials      371      371            
Flag Coverage Δ
uitests 57.35% <53.83%> (-0.03%) ⬇️
unittests 52.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/api/loki.ts 85.71% <ø> (ø)
...eb/src/components/drawer/element/element-field.tsx 100.00% <100.00%> (ø)
...b/src/components/drawer/element/element-fields.tsx 51.61% <100.00%> (ø)
...omponents/drawer/element/element-panel-content.tsx 68.57% <100.00%> (ø)
...omponents/drawer/element/element-panel-metrics.tsx 83.33% <100.00%> (ø)
.../components/drawer/element/element-panel-stats.tsx 86.36% <100.00%> (ø)
...eb/src/components/drawer/element/element-panel.tsx 72.41% <100.00%> (ø)
web/src/components/drawer/record/record-field.tsx 53.01% <100.00%> (ø)
web/src/components/drawer/record/record-panel.tsx 50.00% <100.00%> (ø)
...src/components/metrics/components/brush-handle.tsx 37.50% <ø> (ø)
... and 53 more

Copy link

openshift-ci bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants