Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-648 Put unimplemented panels behind feature gates #219

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Oct 25, 2022

This PR remove overview feature gate on its tab and adds it on the following panels:

  • Network overview
  • Top 5 flows distribution
  • Packets dropped
  • Inbound flows by region

image

@jotak
Copy link
Member

jotak commented Oct 26, 2022

Also as part of finalizing the dashboards, there's the question: do we keep all the available charts enabled by default? Or should we have some of them disabled - only available through the manage panel?

@jpinsonneau
Copy link
Contributor Author

Also as part of finalizing the dashboards, there's the question: do we keep all the available charts enabled by default? Or should we have some of them disabled - only available through the manage panel?

As we only have 6 panels for now I think it's fine to keep everything.
With more panels we will for sure need to focus more on the order / default ones and add capabilities on view display (save / load / sizing / drag & drop etc)

@jotak
Copy link
Member

jotak commented Oct 26, 2022

I guess this PR can go in without these changes, but my remark was more related to the fact some panels are redundant (as discussed in slack too) - I was hoping to fix that before removing the feature gate, but that's ok, not such a big deal to do it after.

@jotak
Copy link
Member

jotak commented Oct 26, 2022

/lgtm

@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3b12f3e into netobserv:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants