Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-399 Table rows display issue after update #177

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Jun 16, 2022

This PR fixes the following issues that happens on query changes after scrolling:
image

It adds data-last-render attribute containing a timestamp on every tr and remove previous ones (if any) every time flows are updated.
This seems to be a bug in PF TableComposable that sometimes keeps previous rows when multiple refresh occurs on the same table instance.

I have also took the opportunity to update dependencies 😺

@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from jpinsonneau after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau jpinsonneau requested a review from jotak June 16, 2022 13:31
@jpinsonneau jpinsonneau marked this pull request as draft June 16, 2022 14:35
@jpinsonneau jpinsonneau removed the request for review from jotak June 16, 2022 14:35
@jotak jotak added this to the v0.1.3 milestone Jun 16, 2022
Copy link

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to reproduce the issue by several means and I couldn't, so I guess it's ok.

@openshift-ci openshift-ci bot added the lgtm label Jun 20, 2022
@jpinsonneau jpinsonneau merged commit a324d99 into netobserv:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants