Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-384 Update deprecated console resource tab #174

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Jun 13, 2022

  • Update deprecated resource/tab
  • Added tabs
    • Route (from related service)
    • Node
    • ReplicaSet (from owner ref)
    • HorizontalPodAutoscaler (from scale target)
  • Force maximum tab height

image

It seems that double scroll bar came back with latest console version in tabs. I have restored the max-height for this case.

@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from jpinsonneau after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mariomac
Copy link

I have been testing it but I can't see any difference with the previous version. ¿Is that ok or should I see something different?

@jpinsonneau
Copy link
Contributor Author

jpinsonneau commented Jun 14, 2022

I have been testing it but I can't see any difference with the previous version. ¿Is that ok or should I see something different?

You should see new tabs in:

  • Route
  • Node
  • ReplicaSet
  • HorizontalPodAutoscaler

@mariomac
Copy link

mariomac commented Jun 14, 2022

Ah thanks! I didn't find them.

Another question.This is the normal netflow table's filter:
image

The "embedded" filter seems to be more compact. Is this intended or are we missing a separation between both rows?

image

@jpinsonneau
Copy link
Contributor Author

The "embedded" filter seems to be more compact. Is this intended or are we missing a separation between both rows?

Yeah this was intended since tabs implementation.

Would you prefer something like this ?
image

@mariomac
Copy link

Would you prefer something like this ?

Looks cleaner for me, but I understand that we want to save space.

@jpinsonneau
Copy link
Contributor Author

Looks cleaner for me, but I understand that we want to save space.

Done 😸
Thanks @mariomac !

@openshift-ci openshift-ci bot added the lgtm label Jun 14, 2022
@jpinsonneau jpinsonneau merged commit 18131fd into netobserv:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants