-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-223: filter by empty names #166
Conversation
Should it manage empty port ? Currently the frontend doesn't allow empty / "" Also the same with Protocol. I'm not sure if we should manage them or not 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works fine with namespaces / name / kind / owner name / node name
@jpinsonneau I see. The original task definition was talking about Kube metadata (text) but it's true that we could extend it to any other field type, like IPs or numbers. If we agree to do it also for other field types, we could do it into another PR so we do it more incremental. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Allows filtering by empty string names.
This PR doesn't include searching by empty IP.