NETOBSERV-287 Aggregate stats, fix limit reach #136
Conversation
| const aggQR: AggregatedQueryResponse = r.data; | ||
| return { | ||
| records: (aggQR.result as StreamResult[]).flatMap(r => parseStream(r)), | ||
| stats: aggQR.stats | ||
| }; |
There was a problem hiding this comment.
Need to do the same logic in getTopology
There was a problem hiding this comment.
return (r.data.data.result as TopologyMetrics[]) needs to be return (r.data.result as TopologyMetrics[])
| .then(result => { | ||
| setFlows(result.records); | ||
| setStats(result.stats); | ||
| }) |
There was a problem hiding this comment.
Also update case 'topology': below
- Stats are now aggregated in backend (needed when multiple queries are performed) - Add a few tests - On the frontend, limit reached now comes as a stats provided from backend - Add info tooltip on limit setting, to clarify it's the limit per loki query, so we may end up with more flows than this limit
|
Thanks, yeah I forgot about topology on the frontend, should be fixed now. |
|
thanks Julien |
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
backend
query, so we may end up with more flows than this limit