Skip to content

Commit

Permalink
Define the SHELL variable in the Makefile (#221)
Browse files Browse the repository at this point in the history
The default value is '/bin/sh'. https://www.gnu.org/software/make/manual/html_node/Choosing-the-Shell.html
In Ubuntu, '/bin/sh' is a symlink to dash. https://wiki.ubuntu.com/DashAsBinSh
And dash doesn't support the source command that's used later in the Makefile.
  • Loading branch information
ronensc authored Oct 26, 2022
1 parent 4b93d40 commit 22cd333
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ BUILD_DATE := $(shell date +%Y-%m-%d\ %H:%M)
# You can add GO Build flags like -gcflags=all="-N -l" here to remove optimizations for debugging
BUILD_FLAGS ?= -ldflags "-X 'main.buildVersion=${BUILD_VERSION}' -X 'main.buildDate=${BUILD_DATE}'"
BUILD_SHA := $(shell git rev-parse --short HEAD)
SHELL := /bin/bash

BASE_IMAGE ?= quay.io/${IMG_USER}/network-observability-console-plugin
IMAGE ?= ${BASE_IMAGE}:${TAG}
Expand Down

0 comments on commit 22cd333

Please sign in to comment.