Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-1805: make sure to cleanup pod veth's hooks when pods is deleted #399

Merged
merged 1 commit into from
Sep 5, 2024
Merged

NETOBSERV-1805: make sure to cleanup pod veth's hooks when pods is deleted #399

merged 1 commit into from
Sep 5, 2024

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Aug 27, 2024 •
edited
Loading

Description

Today ebpf agent only cleanup pods when the pod restarts but in this issue pods where continosly recreated but it was never deleted causing the fd leak

this issue only in v1.6.1 releases because of #358 fix partily and introduction of TCX hook

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 27, 2024 •
edited by openshift-ci bot
Loading

@msherif1234: This pull request references NETOBSERV-1805 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Description

Today ebpf agent only cleanup pods when the pod restarts but in this issue pods where continosly recreated but it was never deleted causing the fd leak

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 4.47761% with 128 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@c6f33c1). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ebpf/tracer.go 0.00% 87 Missing ⚠️
pkg/agent/packets_agent.go 0.00% 18 Missing ⚠️
pkg/agent/agent.go 27.27% 15 Missing and 1 partial ⚠️
pkg/test/tracer_fake.go 0.00% 5 Missing ⚠️
pkg/ifaces/watcher.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #399   +/-   ##
=======================================
  Coverage        ?   29.25%           
=======================================
  Files           ?       49           
  Lines           ?     4187           
  Branches        ?        0           
=======================================
  Hits            ?     1225           
  Misses          ?     2857           
  Partials        ?      105
Flag Coverage Δ
unittests 29.25% <4.47%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/ifaces/watcher.go 60.31% <0.00%> (ø)
pkg/test/tracer_fake.go 52.94% <0.00%> (ø)
pkg/agent/agent.go 34.81% <27.27%> (ø)
pkg/agent/packets_agent.go 0.00% <0.00%> (ø)
pkg/ebpf/tracer.go 0.00% <0.00%> (ø)

@msherif1234 msherif1234 force-pushed the leaking_fd branch 2 times, most recently from 51bb695 to 45c749d Compare August 27, 2024 22:04
@msherif1234 msherif1234 changed the title NETOBSERV-1805: make sure to cleanup pod veth's hooks when pods is deleted WIP NETOBSERV-1805: make sure to cleanup pod veth's hooks when pods is deleted Aug 27, 2024
stleerh
stleerh approved these changes Aug 29, 2024
View reviewed changes
Copy link

@stleerh stleerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 29, 2024
@openshift-ci openshift-ci bot removed the lgtm label Aug 30, 2024
@msherif1234 msherif1234 changed the title WIP NETOBSERV-1805: make sure to cleanup pod veth's hooks when pods is deleted NETOBSERV-1805: make sure to cleanup pod veth's hooks when pods is deleted Aug 30, 2024
@memodi
Copy link
Contributor

memodi commented Aug 30, 2024

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 30, 2024
@github-actions GitHub Actions
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:a222950

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=a222950 make set-agent-image

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 31, 2024 •
edited by openshift-ci bot
Loading

@msherif1234: This pull request references NETOBSERV-1805 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Description

Today ebpf agent only cleanup pods when the pod restarts but in this issue pods where continosly recreated but it was never deleted causing the fd leak

this issue only in v1.6.1 releases because of #358 fix

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 31, 2024 •
edited by openshift-ci bot
Loading

@msherif1234: This pull request references NETOBSERV-1805 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Description

Today ebpf agent only cleanup pods when the pod restarts but in this issue pods where continosly recreated but it was never deleted causing the fd leak

this issue only in v1.6.1 releases because of #358 fix partily and introduction of TCX hook

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 4, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

New image:
quay.io/netobserv/netobserv-ebpf-agent:9faa922

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=9faa922 make set-agent-image

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 4, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

New image:
quay.io/netobserv/netobserv-ebpf-agent:9e63f5b

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=9e63f5b make set-agent-image

@msherif1234
NETOBSERV-1805: make sure to cleanup pod veth's hooks when pods is de…
6a5afe6 
…leted

Today ebpf agent only cleanup pods when the pod restarts
but in this issue pods where continosly recreated but
it was never deleted causing the fd leak

Signed-off-by: Mohamed Mahmoud <[email protected]>
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 4, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

New image:
quay.io/netobserv/netobserv-ebpf-agent:ca3d9ec

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=ca3d9ec make set-agent-image

@memodi
Copy link
Contributor

memodi commented Sep 4, 2024

this change likely affects all OCP versions, tested with 4.14, 4.16, 4.17. Also regression tested SRIOV secondary interfaces scenario.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Sep 4, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 4, 2024 •
edited by openshift-ci bot
Loading

@msherif1234: This pull request references NETOBSERV-1805 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Description

Today ebpf agent only cleanup pods when the pod restarts but in this issue pods where continosly recreated but it was never deleted causing the fd leak

this issue only in v1.6.1 releases because of #358 fix partily and introduction of TCX hook

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm label Sep 5, 2024
@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 5, 2024
@msherif1234 msherif1234 closed this Sep 5, 2024
@msherif1234 msherif1234 reopened this Sep 5, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 5, 2024 •
edited by openshift-ci bot
Loading

@msherif1234: This pull request references NETOBSERV-1805 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Description

Today ebpf agent only cleanup pods when the pod restarts but in this issue pods where continosly recreated but it was never deleted causing the fd leak

this issue only in v1.6.1 releases because of #358 fix partily and introduction of TCX hook

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 5, 2024
@memodi
Copy link
Contributor

memodi commented Sep 5, 2024

/retest

@memodi
Copy link
Contributor

memodi commented Sep 5, 2024

/test ci/prow/unit

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 5, 2024

@memodi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images

Use /test all to run all jobs.

In response to this:

/test ci/prow/unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@memodi
Copy link
Contributor

memodi commented Sep 5, 2024

/test unit

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 5, 2024

@memodi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images

Use /test all to run all jobs.

In response to this:

/test unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@memodi
Copy link
Contributor

memodi commented Sep 5, 2024

/test all

@openshift-merge-bot openshift-merge-bot bot merged commit 43c0aca into netobserv:main Sep 5, 2024
16 checks passed
jotak pushed a commit to jotak/netobserv-agent that referenced this pull request Sep 9, 2024
@msherif1234 @jotak
NETOBSERV-1805: make sure to cleanup pod veth's hooks when pods is de…
f02429f 
…leted (netobserv#399)

Today ebpf agent only cleanup pods when the pod restarts
but in this issue pods where continosly recreated but
it was never deleted causing the fd leak

Signed-off-by: Mohamed Mahmoud <[email protected]>
@jotak jotak mentioned this pull request Sep 9, 2024
Merged
11 tasks
jotak added a commit that referenced this pull request Sep 10, 2024
@jotak @msherif1234 @dependabot
NETOBSERV-1805: make sure to cleanup pod veth's hooks when pods is de…
28f8fe0 
…… [Backport 1.6] (#404)

* NETOBSERV-1805: make sure to cleanup pod veth's hooks when pods is deleted (#399)

Today ebpf agent only cleanup pods when the pod restarts
but in this issue pods where continosly recreated but
it was never deleted causing the fd leak

Signed-off-by: Mohamed Mahmoud <[email protected]>

* update protobuf

* NETOBSERV-1707: move to go 1.22 (#349)

* NETOBSERV-1707: move to go 1.22

* update protobfu

* Bump golang.org/x/sys from 0.20.0 to 0.21.0 (#356)

Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.20.0 to 0.21.0.
- [Commits](golang/sys@v0.20.0...v0.21.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump k8s.io/client-go from 0.29.4 to 0.30.2 (#352)

* Bump k8s.io/client-go from 0.29.4 to 0.30.2

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.29.4 to 0.30.2.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.29.4...v0.30.2)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix go.mod

Signed-off-by: Mohamed Mahmoud <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Mohamed Mahmoud <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mohamed Mahmoud <[email protected]>

* Bump sigs.k8s.io/e2e-framework from 0.3.0 to 0.4.0 (#354)

* Bump sigs.k8s.io/e2e-framework from 0.3.0 to 0.4.0

Bumps [sigs.k8s.io/e2e-framework](https://github.com/kubernetes-sigs/e2e-framework) from 0.3.0 to 0.4.0.
- [Release notes](https://github.com/kubernetes-sigs/e2e-framework/releases)
- [Changelog](https://github.com/kubernetes-sigs/e2e-framework/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/e2e-framework@v0.3.0...v0.4.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/e2e-framework
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix go.mod

Signed-off-by: Mohamed Mahmoud <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Mohamed Mahmoud <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mohamed Mahmoud <[email protected]>

* Bump google.golang.org/protobuf from 1.34.1 to 1.34.2 (#355)

Bumps google.golang.org/protobuf from 1.34.1 to 1.34.2.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/vladimirvivien/gexe from 0.2.0 to 0.3.0 (#361)

Bumps [github.com/vladimirvivien/gexe](https://github.com/vladimirvivien/gexe) from 0.2.0 to 0.3.0.
- [Release notes](https://github.com/vladimirvivien/gexe/releases)
- [Commits](vladimirvivien/gexe@v0.2.0...v0.3.0)

---
updated-dependencies:
- dependency-name: github.com/vladimirvivien/gexe
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/netobserv/flowlogs-pipeline (#362)

Bumps [github.com/netobserv/flowlogs-pipeline](https://github.com/netobserv/flowlogs-pipeline) from 0.1.12-0.20240325100124-fd783b283c7c to 1.6.1-crc0.
- [Release notes](https://github.com/netobserv/flowlogs-pipeline/releases)
- [Commits](https://github.com/netobserv/flowlogs-pipeline/commits/v1.6.1-crc0)

---
updated-dependencies:
- dependency-name: github.com/netobserv/flowlogs-pipeline
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump golang.org/x/sys from 0.21.0 to 0.22.0 (#365)

Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.21.0 to 0.22.0.
- [Commits](golang/sys@v0.21.0...v0.22.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump google.golang.org/grpc from 1.63.2 to 1.65.0 (#366)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.63.2 to 1.65.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.63.2...v1.65.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump k8s.io/client-go from 0.30.2 to 0.30.3 (#372)

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.30.2 to 0.30.3.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.30.2...v0.30.3)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: Mohamed Mahmoud <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Mohamed S. Mahmoud <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stleerh stleerh stleerh approved these changes

@jotak jotak jotak approved these changes

Assignees

@jotak jotak

@stleerh stleerh

Labels
approved jira/valid-reference lgtm qe-approved QE has approved this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msherif1234 @openshift-ci-robot @memodi @jotak @stleerh