Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1151: move flp decode grpc pipe to netobserv agent to avoid flp code updates #168

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jul 31, 2023

move FLP grpc decode logic to the agent to just limit flp to pkg update w/o need to do any code changes

@msherif1234 msherif1234 changed the title WIP: move flp decode grpc pipe to netobserv agent to avoid flp updates WIP: NETOBSERV-1151: move flp decode grpc pipe to netobserv agent to avoid flp updates Jul 31, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 31, 2023

@msherif1234: This pull request references NETOBSERV-1151 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 28.93% and project coverage change: -1.25% ⚠️

Comparison is base (02e1414) 39.51% compared to head (d0a6445) 38.27%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   39.51%   38.27%   -1.25%     
==========================================
  Files          31       32       +1     
  Lines        2394     2712     +318     
==========================================
+ Hits          946     1038      +92     
- Misses       1391     1615     +224     
- Partials       57       59       +2     
Flag Coverage Δ
unittests 38.27% <28.93%> (-1.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/decode/decode_protobuf.go 28.93% <28.93%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msherif1234 msherif1234 changed the title WIP: NETOBSERV-1151: move flp decode grpc pipe to netobserv agent to avoid flp updates NETOBSERV-1151: move flp decode grpc pipe to netobserv agent to avoid flp updates Aug 1, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 1, 2023

@msherif1234: This pull request references NETOBSERV-1151 which is a valid jira issue.

In response to this:

move FLP grpc decode logic to the agent to just limit flp to pkg update w/o need to do any code changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234 msherif1234 changed the title NETOBSERV-1151: move flp decode grpc pipe to netobserv agent to avoid flp updates NETOBSERV-1151: move flp decode grpc pipe to netobserv agent to avoid flp code updates Aug 1, 2023
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

New image:
quay.io/netobserv/netobserv-ebpf-agent:313dccc

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=313dccc make set-agent-image

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 7, 2023
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 23, 2023
@github-actions
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:323ef13

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=323ef13 make set-agent-image

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 8, 2023
@Amoghrd
Copy link

Amoghrd commented Sep 12, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 12, 2023
@github-actions
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:14e6221

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=14e6221 make set-agent-image

@Amoghrd
Copy link

Amoghrd commented Sep 12, 2023

Ran the full-suite of automated regression tests for the above eBPF image. All except SCTP test-case passed(which is known issue, being investigated; issue unrelated to this PR). 204887

@Amoghrd
Copy link

Amoghrd commented Sep 13, 2023

Also regression tested the PacketDrop feature and its working as expected!

@Amoghrd
Copy link

Amoghrd commented Sep 13, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Sep 13, 2023
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 18, 2023
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, decode_protobuf.go is up to date right now. I would suggest to merge to avoid having to sync it again and again 😸

@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f87021a into netobserv:main Sep 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants