NETOBSERV-666: K8s decoration not adding namespace if empty #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #335 +/- ##
==========================================
+ Coverage 69.12% 69.28% +0.15%
==========================================
Files 86 86
Lines 4907 4909 +2
==========================================
+ Hits 3392 3401 +9
+ Misses 1303 1293 -10
- Partials 212 215 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jpinsonneau
approved these changes
Nov 25, 2022
There was a problem hiding this comment.
Should we also do this to all enriched fields ? 🤔
I don't think I saw that on other ones but it could be a safety belt for us
LGTM, thanks @mariomac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused that empty-string and nil namespaces were treated differently in some metrics aggregations:
Now there are no duplicities:
