[REF] Allow integer inputs in freesurfer.parcels_to_vertices()
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integer array inputs will be coerced to float so that they don't fail when we try and insert np.nan
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 64.57% 64.65% +0.08%
==========================================
Files 23 23
Lines 1606 1610 +4
==========================================
+ Hits 1037 1041 +4
Misses 569 569
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84.
Allows integer inputs to
netneurotools.freesurfer.parcels_to_vertices(). Previously this would error due to the insertion ofnp.nanfor "ignored" parcels (e.g., corpus callosum, medial wall).