Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] GH Actions #107

Merged
merged 1 commit into from
Jul 14, 2021
Merged

[FIX] GH Actions #107

merged 1 commit into from
Jul 14, 2021

Conversation

liuzhenqi77
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #107 (be8ae3d) into master (fbdf9a3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   72.00%   72.00%           
=======================================
  Files          26       26           
  Lines        1897     1897           
=======================================
  Hits         1366     1366           
  Misses        531      531           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbdf9a3...be8ae3d. Read the comment docs.

@liuzhenqi77
Copy link
Member Author

Seems caused by this very new issue enthought/mayavi/issues/1057
Fixing vtk==9.0.1 in install_dependencies.sh makes the check work
We could fix it temporarily or ignore this check and wait for their update. 🤷‍♂️

@liuzhenqi77 liuzhenqi77 marked this pull request as ready for review July 14, 2021 17:37
@rmarkello
Copy link
Member

I'm fine for this temporary fix since there's no current timeline on when that'll be resolved! We can monitor it and unpin vtk once it's addressed.

@rmarkello
Copy link
Member

(But brilliant detective work! 🕵️ Thank you so much 🙌)

@rmarkello rmarkello merged commit 503d9ad into netneurolab:master Jul 14, 2021
@liuzhenqi77 liuzhenqi77 deleted the test-action branch July 14, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants