This repository has been archived by the owner on May 22, 2024. It is now read-only.
feat(js): add list of tree shakable external dependencies #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Nov 19, 2020
erezrokah
added
the
type: feature
ehmicky
reviewed
Nov 19, 2020
Looks like I'm hitting the issue described in this thread |
erezrokah
force-pushed
the
feat/tree_shake_externals
branch
2 times, most recently
from
940ca53 to
8756520
Compare
erezrokah
commented
Dec 10, 2020
erezrokah
commented
Dec 10, 2020
erezrokah
force-pushed
the
feat/tree_shake_externals
branch
from
8756520 to
47459a4
Compare
erezrokah
commented
Dec 10, 2020
erezrokah
changed the title
ehmicky
reviewed
Dec 10, 2020
erezrokah
force-pushed
the
feat/tree_shake_externals
branch
2 times, most recently
from
96aeb51 to
9716a60
Compare
ehmicky
reviewed
Dec 15, 2020
ehmicky
reviewed
Dec 15, 2020
ehmicky
reviewed
Dec 15, 2020
erezrokah
force-pushed
the
feat/tree_shake_externals
branch
from
62b35d6 to
dd6a238
Compare
ehmicky
reviewed
Dec 16, 2020
ehmicky
reviewed
Dec 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Still in draft as it needs testing (automated and manual) and some code cleanup.
For some reason I'm getting 500 errors when trying to deploy functions locally so I'm having a hard time trying to test this.
- Test plan
Going to add tests once I'm finished with verifying this locally.
- Description for the changelog
Add a list of tree shakable external modules to help reduce bundle size.
I'm only considering adding an escape hatch for this via a env variable (or any other configuration) so this behavior can be disabled/changed.
- A picture of a cute animal (not mandatory but encouraged)
🐱