chore(deps): update dependency @netlify/eslint-config-node to v6 (#1063)

* chore(deps): update dependency @netlify/eslint-config-node to v6 * chore: fix lockfile * chore: fix linting * chore: fix linting Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: ehmicky <[email protected]>
netlify · Apr 1, 2022 · dc0fe1a · dc0fe1a · github-actions · Apr 1, 2022
1 parent ad9161d
commit dc0fe1a
Show file tree

Hide file tree

Showing 9 changed files with 2,689 additions and 2,242 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -4,7 +4,11 @@ module.exports = {
   extends: '@netlify/eslint-config-node',
   rules: {
     'import/extensions': ['error', 'ignorePackages'],
-    'node/no-missing-import': 'off',
+    'n/no-missing-import': 'off',
+    // This is disabled because TypeScript transpiles some features currently
+    // unsupported by Node 12, i.e. optional chaining
+    // TODO: re-enable after dropping support for Node 12
+    'n/no-unsupported-features/es-syntax': 'off',
     // This rule enforces using Buffers with `JSON.parse()`. However, TypeScript
     // does not recognize yet that `JSON.parse()` accepts Buffers as argument.
     'unicorn/prefer-json-parse-buffer': 'off',

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -12,9 +12,9 @@ Explain the **motivation** for making this change. What existing problem does th
 
 For us to review and ship your PR efficiently, please perform the following steps:
 
-- [ ] Open a [bug/issue](https://github.com/netlify/zip-it-and-ship-it/issues/new/choose) before writing your code
-      🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you\`re
-      fixing a typo or something that\`s on fire 🔥 (e.g. incident related), you can skip this step.
+- [ ] Open a [bug/issue](https://github.com/netlify/zip-it-and-ship-it/issues/new/choose) before writing your code 🧑‍💻.
+      This ensures we can discuss the changes and get feedback from everyone that should be involved. If you\`re fixing
+      a typo or something that\`s on fire 🔥 (e.g. incident related), you can skip this step.
 - [ ] Read the [contribution guidelines](../CONTRIBUTING.md) 📖. This ensures your code follows our style guide and
       passes our tests.
 - [ ] Update or add tests (if any source code was changed or added) 🧪

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -86,7 +86,7 @@
   },
   "devDependencies": {
     "@babel/types": "^7.15.6",
-    "@netlify/eslint-config-node": "^5.1.8",
+    "@netlify/eslint-config-node": "^6.0.0",
     "@types/archiver": "^5.1.1",
     "@types/end-of-stream": "^1.4.1",
     "@types/resolve": "^1.20.1",

diff --git a/tests/fixtures/dynamic-import/.eslintrc b/tests/fixtures/dynamic-import/.eslintrc
@@ -1,6 +1,6 @@
 {
   "parserOptions": { "sourceType": "module" },
   "rules": {
-    "node/no-unsupported-features/es-syntax": 0
+    "n/no-unsupported-features/es-syntax": 0
   }
 }
diff --git a/tests/fixtures/in-source-config/functions/cron_esm.js b/tests/fixtures/in-source-config/functions/cron_esm.js
@@ -1,7 +1,7 @@
-// eslint-disable-next-line node/no-unsupported-features/es-syntax
+// eslint-disable-next-line n/no-unsupported-features/es-syntax
 import { schedule } from '@netlify/functions'
 
-// eslint-disable-next-line node/no-unsupported-features/es-syntax
+// eslint-disable-next-line n/no-unsupported-features/es-syntax
 export const handler = schedule('@daily', () => {
   // function handler
 })
diff --git a/tests/fixtures/in-source-config/functions/cron_esm_renamed.js b/tests/fixtures/in-source-config/functions/cron_esm_renamed.js
@@ -1,7 +1,7 @@
-// eslint-disable-next-line node/no-unsupported-features/es-syntax
+// eslint-disable-next-line n/no-unsupported-features/es-syntax
 import { schedule as somethingElse } from '@netlify/functions'
 
-// eslint-disable-next-line node/no-unsupported-features/es-syntax
+// eslint-disable-next-line n/no-unsupported-features/es-syntax
 export const handler = somethingElse('@daily', () => {
   // function handler
 })
diff --git a/tests/fixtures/in-source-config/functions/cron_ts.ts b/tests/fixtures/in-source-config/functions/cron_ts.ts
@@ -1,9 +1,9 @@
-// eslint-disable-next-line node/no-unsupported-features/es-syntax
+// eslint-disable-next-line n/no-unsupported-features/es-syntax
 import { schedule } from '@netlify/functions'
 
 const str: string = 'hello'
 
-// eslint-disable-next-line node/no-unsupported-features/es-syntax
+// eslint-disable-next-line n/no-unsupported-features/es-syntax
 export const handler = schedule('@daily', () => {
   console.log(str)
 })
diff --git a/tests/fixtures/in-source-config/functions/cron_ts_renamed.ts b/tests/fixtures/in-source-config/functions/cron_ts_renamed.ts
@@ -1,9 +1,9 @@
-// eslint-disable-next-line node/no-unsupported-features/es-syntax
+// eslint-disable-next-line n/no-unsupported-features/es-syntax
 import { schedule as somethingElse } from '@netlify/functions'
 
 const str: string = 'hello'
 
-// eslint-disable-next-line node/no-unsupported-features/es-syntax
+// eslint-disable-next-line n/no-unsupported-features/es-syntax
 export const handler = somethingElse('@daily', () => {
   console.log(str)
 })