This repository has been archived by the owner on Oct 10, 2022. It is now read-only.
fix(deps)!: update dependency node-fetch to v3 #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
ehmicky
changed the title
ehmicky
reviewed
Feb 7, 2022
| } | ||
| } | ||
|
|
||
| const addFallbackErrorMessage = function (error, textResponse) { | ||
| error.message = error.message || textResponse |
There was a problem hiding this comment.
The new version of node-fetch makes the error message now empty in some cases.
https://github.com/node-fetch/node-fetch/blob/main/docs/v3-UPGRADE-GUIDE.md#responsestatustext-no-longer-sets-a-default-message-derived-from-the-http-status-code
ehmicky
reviewed
Feb 7, 2022
| export const getFetchError = function (error, url, opts) { | ||
| const data = omit.default(opts, ['Authorization']) | ||
| error.name = 'FetchError' | ||
| if (error.name !== 'FetchError') { |
There was a problem hiding this comment.
error.name is now non-writable on FetchError.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^2.6.1->^3.0.0Release Notes
node-fetch/node-fetch
v3.2.0Compare Source
Features
v3.1.1Compare Source
Security patch release
Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred
What's Changed
New Contributors
Full Changelog: node-fetch/node-fetch@v3.1.0...v3.1.1
v3.1.0Compare Source
What's Changed
Body.bodyinto anode:streamby @jimmywarting in https://github.com/node-fetch/node-fetch/pull/924urltoURLby @dhritzkiv in https://github.com/node-fetch/node-fetch/pull/1318BodyMixin.formData()and constructing bodies with FormData by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1314New Contributors
Full Changelog: node-fetch/node-fetch@v3.0.0...v3.1.0
v3.0.0Compare Source
version 3 is going out of a long beta period and switches to stable
One major change is that it's now a ESM only package
See changelog for more information about all the changes.
Configuration
📅 Schedule: "before 3am on Monday" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.