Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: use eslint-plugin-n instead of eslint-plugin-node #482

Merged
merged 1 commit into from
Apr 1, 2022
Merged

fix!: use eslint-plugin-n instead of eslint-plugin-node #482

merged 1 commit into from
Apr 1, 2022

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Apr 1, 2022

See #321 (comment)

eslint-plugin-node is unmaintained and eslint-plugin-n is a maintained fork.
This will allow us to upgrade to ESLint v8.

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • The status checks are successful (continuous integration). Those can be seen below.

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Apr 1, 2022
@ehmicky ehmicky requested a review from erezrokah April 1, 2022 15:23
@ehmicky ehmicky self-assigned this Apr 1, 2022
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Apr 1, 2022
erezrokah
erezrokah approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is breaking change for this library if we need to rename rules in consumers?

Can we merge with fix!: ...?

@ehmicky ehmicky force-pushed the fix/eslint-plugin-n branch from 0e66f3c to d0cb9a5 Compare April 1, 2022 15:48
@ehmicky
Copy link
Contributor Author

ehmicky commented Apr 1, 2022

Right, great call @erezrokah!

@ehmicky ehmicky changed the title fix: use eslint-plugin-n instead of eslint-plugin-node fix!: use eslint-plugin-n instead of eslint-plugin-node Apr 1, 2022
@ehmicky ehmicky added automerge and removed type: bug code to address defects in shipped code labels Apr 1, 2022
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Apr 1, 2022
@kodiakhq kodiakhq bot merged commit df03ffe into main Apr 1, 2022
@kodiakhq kodiakhq bot deleted the fix/eslint-plugin-n branch April 1, 2022 15:52
@token-generator-app token-generator-app bot mentioned this pull request Apr 1, 2022
Merged
@erezrokah
Copy link
Contributor

This was a breaking change, but not in the way we expected? https://github.com/netlify/cli/runs/5791278004?check_suite_focus=true#step:7:17

@ehmicky
Copy link
Contributor Author

ehmicky commented Apr 1, 2022

Re-building package-lock.json fixes it.
Also any references to eslint-plugin-node (in .eslintrc.* or as eslint-disable comments) must be renamed to eslint-plugin-n.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezrokah erezrokah erezrokah approved these changes

Assignees

@ehmicky ehmicky

Labels
automerge type: bug code to address defects in shipped code type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehmicky @erezrokah