-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PF-52] - Do not export empty events #40
Conversation
Release 1.3.5
- increase version
- update github workflows
- add isEmpty function to determine if event should be exported - in future releases it could be implemented for each model class
- update string check
- update test to assert that empty events are not present in exported xml file, add empty events to test xml
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Description
Implements PF-52. Adds
isEmpty
function used to determine if object should be exported. In the future it could be implemented for all model classes.