API token is passed to retrieve NetBox version #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the `version` property in `pynetbox/core/api.py` to pass the API token when calling `get_version`. - No problem raised even if the token is None - This change addresses the issue where `nb.version` returns an empty string when using an OIDC proxy, due to unauthorized requests being redirected to the login page.
rondemena
approved these changes
Sep 6, 2024
|
It was not my intent to trigger git checks and move to the next step but to bring relevance to the fix is desired in other places and reinforce the proposed change, apologies to the maintainers. |
|
someone correct me if I'm wrong but isn't this already addressed and merged in #616 |
I don't think so. With our specific configuration, where a redirect occurs when the user is not authorized, it won't trigger a 403 error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #640
versionproperty inpynetbox/core/api.pyto pass the API token when callingget_version.nb.versionreturns an empty string when using an OIDC proxy, due to unauthorized requests being redirected to the login page.Closes #640